sarutak opened a new pull request, #56770: URL: https://github.com/apache/spark/pull/56770
### What changes were proposed in this pull request? Add spill-path tests for `SortMergeAsOfJoinExec` directions and join types not covered by the existing backward+inner spill test added in #56595: - Forward join with spill - Nearest join with spill - Left outer join with spill (null-fill path) All tests force `ExternalAppendOnlyUnsafeRowArray` to spill by setting `spark.sql.sortMergeJoinExec.buffer.in.memory.threshold` and `spark.sql.sortMergeJoinExec.buffer.spill.threshold` to 1. ### Why are the changes needed? Requested in #56595 review: the spill test added there only covered the Backward + Inner path (`findBestBackwardForward`). The Forward/Nearest path (`findBestForwardNearest`) and the LeftOuter null-fill path have their own `.copy()` over the reused `SpillableArrayIterator` row and were not exercised under spill conditions. ### Does this PR introduce *any* user-facing change? No. ### How was this patch tested? New tests in `SortMergeAsOfJoinSuite`. ### Was this patch authored or co-authored using generative AI tooling? Kiro CLI / Claude -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
