max2718281 commented on code in PR #56516:
URL: https://github.com/apache/spark/pull/56516#discussion_r3476146304
##########
core/src/main/scala/org/apache/spark/resource/ResourceProfileManager.scala:
##########
@@ -160,19 +190,4 @@ private[spark] class ResourceProfileManager(sparkConf:
SparkConf,
readLock.unlock()
}
}
-
- /*
- * If the ResourceProfile passed in is equivalent to an existing one, return
the
- * existing one, other return None
- */
- def getEquivalentProfile(rp: ResourceProfile): Option[ResourceProfile] = {
Review Comment:
Logic changes LGTM. The only thing I'm not sure of is whether
`getEquivalentProfile` is considered a public API and backwards compatibility
should be maintained. WDYT? @mridulm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
