HyukjinKwon commented on PR #56788: URL: https://github.com/apache/spark/pull/56788#issuecomment-4804787736
Closing in favor of #56789 (agent6), which is the correct fix. I verified locally (Python 3.12) that numpy 2.5 declares `NDArray` as a PEP 695 `type` alias, so `NDArray[int].__origin__` is a `TypeAliasType` (with `__value__`) and `__args__` is `(int,)`. The approach in this PR (unwrapping `__origin__` / scanning for `np.dtype[...]`) dead-ends on the `TypeAliasType` and returns `None`, so it would not actually resolve the element type. #56789 detects the `TypeAliasType` and resolves it correctly. Superseded. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
