HyukjinKwon commented on code in PR #56783: URL: https://github.com/apache/spark/pull/56783#discussion_r3478134657
########## .github/workflows/build_scala213.yml: ########## @@ -17,37 +17,22 @@ # under the License. # -name: "Build (branch-3.5, Scala 2.13, JDK 8)" +# This is a placeholder. Scala 2.13 is the default on master, so there is no Review Comment: Nice trick, and the comment here explains it well. One gap: the PR description says it "removes the per-build `build_branch35*.yml` files from master," but they're actually renamed to these no-op placeholders and deliberately kept — because a README badge resolves its workflow by path on the default branch, so the file must exist on master for the `?branch=branch-3.5` badge to render. Worth stating that in the PR description too: a maintainer who reads "removed" might later delete these no-op files as dead code and silently break the branch-3.5 badges. (Verified `build_scala213.yml` / `build_python_3.9.yml` / `build_main.yml` all exist on `branch-3.5`, so the scheduler triggers and badges resolve correctly.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
