shrirangmhalgi commented on code in PR #56766:
URL: https://github.com/apache/spark/pull/56766#discussion_r3478807078
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala:
##########
@@ -700,6 +700,7 @@ object FunctionRegistry {
expressionBuilder("curdate", CurDateExpressionBuilder, setAlias = true),
expression[CurrentTimestamp]("current_timestamp"),
expression[CurrentTime]("current_time"),
+ expression[CurrentTime]("localtime", since = Some("4.3.0")),
Review Comment:
Acknowledged. This mirrors how `now()` labels as `current_timestamp()`.
Making `localtime()` self-label would require a separate expression class
(can't override `prettyName` on a case class alias). I would prefer to leave
it consistent with the existing alias pattern for now - happy to refactor in a
follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
