HyukjinKwon commented on PR #56718: URL: https://github.com/apache/spark/pull/56718#issuecomment-4806820440
Thanks for the review @uros-b! Addressed in f88ded6: - **Coverage gap (your inline nit):** extended the `RocksDBSuite` test to also exercise the `checkpointUniqueId` state-checkpoint-v2 path (`fm.open`), in addition to the existing no-`checkpointUniqueId` `fs.open` path. It asserts the enriched message names the unique id and lists the present `1_<id>.zip` snapshot. - **Stale reference:** updated `SPARK-57XXX` -> `SPARK-57652` (the test-side deflake) in the description. And folding in the self-review nits: - Preserve the original exception via `initCause(e)` so the underlying stack trace isn't lost. - Dropped the redundant missing-zip path from the enriched message (`e.getMessage` already names it). Promoted out of draft. Re-running CI on the fork to confirm sql#core + the new test stay green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
