uros-b commented on code in PR #56785:
URL: https://github.com/apache/spark/pull/56785#discussion_r3479768564


##########
resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/BaseYarnClusterSuite.scala:
##########
@@ -261,6 +269,15 @@ abstract class BaseYarnClusterSuite extends SparkFunSuite 
with Matchers {
     val props = new Properties()
     props.put(SPARK_JARS.key, "local:" + fakeSparkJar.getAbsolutePath())
 
+    // On a busy CI runner the in-JVM mini cluster, the driver and the 
container JVMs all compete
+    // for CPU, and the driver's RPC server occasionally cannot accept a 
connection in time. With
+    // the default of 3 retries an executor that loses this race gives up and 
exits, which leaves
+    // the application unable to finish and the suite times out. Give the 
executor->driver
+    // connection a larger retry budget so a transient stall does not 
permanently fail the app.
+    // These are defaults; individual tests can still override them via 
extraConf below.
+    props.setProperty("spark.rpc.io.maxRetries", "10")

Review Comment:
   Note: the new spark.rpc.io.* defaults are set via setProperty BEFORE the 
loop that copies spark.* JVM system properties, so a -Dspark.rpc.io.maxRetries 
flag would silently override them; the comment claims only extraConf can 
override. Moving the two setProperty calls to just before extraConf.foreach 
removes the ambiguity.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to