stevomitric opened a new pull request, #56811:
URL: https://github.com/apache/spark/pull/56811

   ### What changes were proposed in this pull request?
   
   Tests-only coverage for SORT / ORDER BY and window functions over the 
nanosecond-precision
   timestamp types `TIMESTAMP_NTZ(p)` / `TIMESTAMP_LTZ(p)` (`p` in `[7, 9]`):
   
   - `TimestampNanosWindowSuiteBase` (+ ANSI on/off): `row_number` / `rank` / 
`dense_rank` / `lag` / `lead` over a nanosecond ordering key, NTZ and LTZ, 
whole-stage codegen on and off. No existing test asserts a window function over 
a *timestamp* ordering key.
   - `TimestampNanosSortSuiteBase` (+ ANSI on/off): the DataFrame/SQL scenarios 
not already covered generically by `OrderingSuite` / `SortSuite` (which 
exercise these types via `DataTypeTestUtils.atomicTypes`) — a public-API `ORDER 
BY` sub-microsecond tie-break smoke test, mixed-precision `UNION` ordering, a 
vectorized-ORC-read-then-sort, and an `intercept` documenting that caching a 
nanosecond column is not supported yet.
   - Golden coverage: a short `ORDER BY` + `row_number` + `lead` section 
appended to `timestamp-ntz-nanos.sql` / `timestamp-ltz-nanos.sql`.
   
   ### Why are the changes needed?
   
   SORT / ORDER BY and window functions already work over the nanosecond types 
(they ride on the orderability / hashing / `UnsafeRow` primitives), but had no 
dedicated test coverage. This locks the behaviour in, mirroring the MIN/MAX 
follow-up which was likewise tests-only. Joins are deferred to a later change.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No, tests only.
   
   ### How was this patch tested?
   
   New suites.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   Generated-by: Claude Code (Claude Opus 4.8)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to