MaxGekk commented on code in PR #56815:
URL: https://github.com/apache/spark/pull/56815#discussion_r3483486127
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/ResolveBinBySuite.scala:
##########
@@ -31,8 +31,8 @@ import org.apache.spark.sql.types._
class ResolveBinBySuite extends AnalysisTest {
- // BIN BY is gated off by default; run the resolution tests with it enabled.
The dedicated
- // gate test below uses `super.test` to observe the default-off behavior.
+ // Run the resolution tests with the operator enabled. The dedicated gate
test below uses
+ // `super.test` to escape this wrapper and pins the flag off.
Review Comment:
Nit: "uses `super.test` to escape this wrapper and **pins** the flag off"
coordinates the infinitive "escape" with the finite "pins". Read it as "…to
escape this wrapper and **pin** the flag off."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
