XdithyX commented on PR #56486: URL: https://github.com/apache/spark/pull/56486#issuecomment-4818761010
Hi @cloud-fan I updated the patch to address the API design concern by replacing the sample-specific join pushdown overload with a context object (`JoinPushDownInfo`) plus an explicit pushed-operator capability check (`supportedPushedOperatorsForJoin`). Existing connectors remain safe by default, and JDBC now opts into preserving `TABLE_SAMPLE`. Also addressed the JavaDoc nit, removed the now-unreachable JDBC sample guard, and updated the PR description to match the final design. Could you please take another look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
