MaxGekk commented on code in PR #56809:
URL: https://github.com/apache/spark/pull/56809#discussion_r3486545138
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/HashBenchmark.scala:
##########
@@ -125,6 +125,7 @@ object HashBenchmark extends BenchmarkBase {
.add("binary", BinaryType)
.add("date", DateType)
.add("timestamp", TimestampType)
+ .add("time", TimeType())
Review Comment:
This adds a `time` column to the `normal` hash schema, but
`HashBenchmark-results.txt` was reverted to `upstream/master` in this commit —
it still has the old hardware header (`17.0.18 / Linux 6.14`) and no time
column. Round 2 (727e46b) had this file correctly regenerated on CI, so the
benchmark runs fine; this commit just dropped the regenerated results while
keeping the schema change.
Your note mentions regenerating "all four" results files (the `sql/core`
ones); `HashBenchmark` lives in `sql/catalyst` and is a fifth modified
benchmark whose results were missed. As committed, the benchmark code and its
results file are out of sync. Please regenerate `HashBenchmark-results.txt` on
the CI runner too (so it reflects the new `time` column), or drop this
`HashBenchmark` schema change if it's out of scope for the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
