dongjoon-hyun commented on code in PR #56842:
URL: https://github.com/apache/spark/pull/56842#discussion_r3487415235
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/columnar/InMemoryColumnarQuerySuite.scala:
##########
@@ -222,6 +222,36 @@ class InMemoryColumnarQuerySuite extends
SharedSparkSession with AdaptiveSparkPl
}
}
+ test("cache nanosecond-precision timestamp types") {
+ withSQLConf(SQLConf.TIMESTAMP_NANOS_TYPES_ENABLED.key -> "true") {
+ Seq("TIMESTAMP_NTZ(9)", "TIMESTAMP_LTZ(9)").foreach { typeName =>
+ Seq("false", "true").foreach { vectorized =>
+ withSQLConf(SQLConf.CACHE_VECTORIZED_READER_ENABLED.key ->
vectorized) {
Review Comment:
SQLConf.CACHE_VECTORIZED_READER_ENABLED.key=true seems to be a dead test
coverage because of the following. Could you double-check, @viirya ?
https://github.com/apache/spark/blob/64fb953b9f2c868992a37033b068e62387535172/sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryRelation.scala#L175-L182
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
