uros-b commented on code in PR #56846:
URL: https://github.com/apache/spark/pull/56846#discussion_r3492571824
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/AggregatePushDownUtils.scala:
##########
@@ -74,8 +74,10 @@ object AggregatePushDownUtils {
// (https://issues.apache.org/jira/browse/PARQUET-1685), Parquet Binary
// could be Spark StringType, BinaryType or DecimalType.
// not push down for ORC with same reason.
+ // TIME is INT64/LONG-backed with a defined sort order, so real min/max
+ // statistics exist in the footer for both Parquet and ORC.
case BooleanType | ByteType | ShortType | IntegerType
- | LongType | FloatType | DoubleType | DateType =>
+ | LongType | FloatType | DoubleType | DateType | _: TimeType =>
Review Comment:
Nit: leading block comment still only explains the exclusions; new inline
comment is good but the older block is now slightly less complete now - please
update
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
