sarutak commented on code in PR #53902:
URL: https://github.com/apache/spark/pull/53902#discussion_r3492526084
##########
sql/core/src/main/scala/org/apache/spark/sql/jdbc/MySQLDialect.scala:
##########
@@ -37,7 +37,8 @@ import org.apache.spark.sql.types._
private case class MySQLDialect() extends JdbcDialect with SQLConfHelper with
NoLegacyJDBCError {
override def canHandle(url : String): Boolean =
- url.toLowerCase(Locale.ROOT).startsWith("jdbc:mysql")
+ url.toLowerCase(Locale.ROOT).startsWith("jdbc:mysql") ||
+ url.toLowerCase(Locale.ROOT).startsWith("jdbc:aws-wrapper:mysql")
Review Comment:
Let's avoid duplicate `toLowerCase` calls. Please extract to a local
variable like:
```scala
override def canHandle(url: String): Boolean = {
val lower = url.toLowerCase(Locale.ROOT)
lower.startsWith("jdbc:mysql") ||
lower.startsWith("jdbc:aws-wrapper:mysql")
}
```
##########
sql/core/src/main/scala/org/apache/spark/sql/jdbc/PostgresDialect.scala:
##########
@@ -41,7 +41,8 @@ private case class PostgresDialect()
extends JdbcDialect with SQLConfHelper with NoLegacyJDBCError {
override def canHandle(url: String): Boolean =
- url.toLowerCase(Locale.ROOT).startsWith("jdbc:postgresql")
+ url.toLowerCase(Locale.ROOT).startsWith("jdbc:postgresql") ||
+ url.toLowerCase(Locale.ROOT).startsWith("jdbc:aws-wrapper:postgresql")
Review Comment:
Ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
