uros-b commented on code in PR #56880:
URL: https://github.com/apache/spark/pull/56880#discussion_r3496947371
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala:
##########
@@ -744,13 +744,13 @@ private[sql] object QueryCompilationErrors extends
QueryErrorsBase with Compilat
def expectPersistentFuncError(
name: String, cmd: String, mismatchHint: Option[String], t:
TreeNode[_]): Throwable = {
- val hintStr = mismatchHint.map(" " + _).getOrElse("")
+ val alternative = mismatchHint.map(" " + _).getOrElse("")
new AnalysisException(
- errorClass = "_LEGACY_ERROR_TEMP_1017",
+ errorClass = "EXPECT_PERSISTENT_FUNCTION_NOT_TEMP",
Review Comment:
Nit: EXPECT_PERSISTENT_FUNCTION_NOT_TEMP wraps cmd in toSQLStmt()
(uppercases), whereas the analogous EXPECT_PERMANENT_VIEW_NOT_TEMP passes cmd
through unchanged. Please align for overall style inconsistency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
