MaxGekk opened a new pull request, #56894: URL: https://github.com/apache/spark/pull/56894
### What changes were proposed in this pull request? This is a follow-up of #56819, addressing the Java 21/25 build failures reported there. #56819 added TIME cases to `try_arithmetic.sql` and regenerated the base golden files. However, `nonansi/try_arithmetic.sql.out` has a Java-21-specific variant `nonansi/try_arithmetic.sql.out.java21` (the suite reads it when `Utils.isJavaVersionAtLeast21`, because JDK-4511638 changes the `toString` of `Float`/`Double`). That `.java21` variant was left stale -- it was missing the new TIME rows -- so on Java 21+ the test compared actual output (with TIME rows) against the stale golden file and failed. This PR adds the new TIME rows to `nonansi/try_arithmetic.sql.out.java21`. The only genuine Java 21 difference in this file remains the `try_divide(1, (2147483647 + 1))` double output: - Java 8/11/17: `-4.6566128730773926E-10` - Java 21+: `-4.656612873077393E-10` The new TIME outputs (time values, NULLs, and day-time intervals) are Java-version stable, so they are identical in the base and `.java21` files. The ANSI `try_arithmetic.sql.out` needs no `.java21` variant because that `try_divide` double query only appears in non-ANSI mode (in ANSI mode the inner `2147483647 + 1` overflows). ### Why are the changes needed? To fix the Java 21/25 build failures observed after #56819 was merged, e.g.: - https://github.com/apache/spark/actions/runs/28359601002/job/84013737500 - https://github.com/apache/spark/actions/runs/28406731869/job/84173152434 ### Does this PR introduce _any_ user-facing change? No. Test-only. ### How was this patch tested? - Verified `nonansi/try_arithmetic.sql.out.java21` differs from the base `nonansi/try_arithmetic.sql.out` by exactly the one `try_divide` double line, consistent with the existing Java 21 golden file convention. - `build/sbt 'sql/testOnly org.apache.spark.sql.SQLQueryTestSuite -- -z try_arithmetic'` ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Cursor -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
