pan3793 commented on code in PR #56890:
URL: https://github.com/apache/spark/pull/56890#discussion_r3497391563
##########
core/src/main/scala/org/apache/spark/util/logging/DriverLogger.scala:
##########
@@ -71,7 +71,9 @@ private[spark] class DriverLogger(conf: SparkConf) extends
Logging {
builder.setBufferedIo(false)
builder.setConfiguration(config)
builder.withFileName(localLogFile)
- builder.setIgnoreExceptions(false)
+ // SPARK-57774: Set to true to avoid propagating log4j internal exception
+ // (e.g., due to log4j bugs) to the caller.
+ builder.setIgnoreExceptions(true)
Review Comment:
I don't think we have any logic to handle exceptions thrown by logging
calls, if users really care about that, maybe they should customize log4j's
internal error handler?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
