urosstan-db commented on code in PR #56899: URL: https://github.com/apache/spark/pull/56899#discussion_r3497865838
########## sql/core/src/main/scala/org/apache/spark/sql/jdbc/PostgresDialect.scala: ########## @@ -259,8 +259,22 @@ private case class PostgresDialect() } // See https://www.postgresql.org/docs/current/errcodes-appendix.html + // Class 42 is "Syntax Error or Access Rule Violation", so it bundles genuine syntax errors + // together with authorization failures. 42501 is the insufficient_privilege state (e.g. Review Comment: Too verbose, can we make this more concise, e.g. ``` // Class 42 mixes syntax and auth errors (https://www.postgresql.org/docs/current/errcodes-appendix.html). // Filter out 42501 and check message keywords because some Postgres-compatible engines // use generic 42000 for auth failures. Never wrap these as JDBC_EXTERNAL_ENGINE_SYNTAX_ERROR. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
