MaxGekk commented on code in PR #56895:
URL: https://github.com/apache/spark/pull/56895#discussion_r3498160343
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala:
##########
@@ -297,6 +297,33 @@ object Analyzer {
}
}
}
+
+ /**
+ * Builds the throwaway [[SQLConf]] used to resolve a SQL UDF body, seeded
from the function's
+ * stored configs. Call sites share this seeding but differ in how they
apply ANSI and session
+ * overrides, so both are parameters:
+ * - `alwaysSetAnsiValue` calls [[trySetAnsiValue]] unconditionally (the
SessionCatalog plan
+ * builders); when false, ANSI is set only as part of the session overlay
below (the
+ * [[ResolveSQLFunctions]] / [[ResolveSQLTableFunctions]] rules).
Review Comment:
Nit (non-blocking): `[[ResolveSQLFunctions]]` /
`[[ResolveSQLTableFunctions]]` are inner objects of `class Analyzer`, so they
aren't in the lexical scope of the companion `object Analyzer` where this
Scaladoc sits — the bare links don't resolve (the other three links here do).
Qualify with the instance-member path:
```suggestion
* [[Analyzer#ResolveSQLFunctions]] /
[[Analyzer#ResolveSQLTableFunctions]] rules).
```
Low severity — Spark doesn't generate/gate Scaladoc in normal builds, so
this won't break CI; the symbols exist and the intent is clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
