cloud-fan commented on code in PR #56712:
URL: https://github.com/apache/spark/pull/56712#discussion_r3499132834
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TableOutputResolver.scala:
##########
@@ -385,7 +437,24 @@ object TableOutputResolver extends SQLConfHelper with
Logging {
}
}
- if (reordered.length == expectedCols.length) {
+ // Resolve auto-filled generated column references against the post-cast
stored columns, so the
+ // generated value is computed from the values as they will be written
(after any
+ // store-assignment cast) Generated columns only exist at the top level,
Review Comment:
Nit: missing period between the two sentences (`cast)` and `Generated`).
```suggestion
// store-assignment cast). Generated columns only exist at the top level,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
