ivan-leventsov commented on code in PR #56898:
URL: https://github.com/apache/spark/pull/56898#discussion_r3499875210
##########
sql/core/src/main/scala/org/apache/spark/sql/jdbc/OracleDialect.scala:
##########
@@ -54,6 +54,13 @@ private case class OracleDialect() extends JdbcDialect with
SQLConfHelper with N
e.getMessage.contains("ORA-39165")
}
+ override def isNotSelectableObjectException(e: SQLException): Boolean = {
+ // ORA-04044: object is not a table (e.g. a synonym to a
procedure/function/package).
+ e.getMessage.contains("ORA-04044") ||
Review Comment:
Yeah, makes sense, but I'd leave it as is in this PR and keep it consistent
with the existing implementation to minimize risk and avoid potential side
effects from this small change (for example, the behavior might differ across
driver versions etc..)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
