shrirangmhalgi commented on PR #56904: URL: https://github.com/apache/spark/pull/56904#issuecomment-4845775914
Thank you @MaxGekk for the review. Addressed all the comments in the latest commit: - Added a `time[]` array read test that exercises the `toCatalystType` array-element path directly - `getJDBCType` now emits `TIME(p)` for `pā[0,6]` and bare `TIME` for out-of-range precisions, preserving the declared precision on round-trip - Added a precision preservation round-trip test (TimeType(3) ā TIME(3) ā read back as TimeType(3)) - Added comment explaining why `DEFAULT_PRECISION` is used for array elements (driver does not report element typmod; 6 = Postgres max) I'll also add the `legacyJdbcTimeMappingEnabled` guard once #56884 merges - the per-dialect `toCatalystType` runs before the default mapper so it needs its own check. Left a TODO in the code for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
