mihailotim-db commented on code in PR #56417:
URL: https://github.com/apache/spark/pull/56417#discussion_r3504003733
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/resolver/AggregateResolver.scala:
##########
@@ -144,25 +147,45 @@ class AggregateResolver(
)
if (resolvedAggregateExpressions.hasLateralColumnAlias) {
+ // LCA + grouping analytics (CUBE/ROLLUP/GROUPING SETS) is not yet
supported in the
+ // single-pass resolver because Expand mints new attribute IDs that
get out of sync
+ // with the Project operator. Fall back to legacy analyzer for correct
results.
+ if
(finalAggregate.groupingExpressions.exists(_.isInstanceOf[BaseGroupingSets])) {
Review Comment:
This doesn't really fix anything, it just disables this case, which is not
ideal. Ideally, we never want to throw `ExplicitlyUnsupportedResolverFeatures`.
Just curious, where did you find the error given that single-pass analyzer is
not enabled in tests currently? I have an e2e fix for this but it will take
some time to merge, so if this is not blocking anything I would until that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
