gaogaotiantian commented on PR #56940:
URL: https://github.com/apache/spark/pull/56940#issuecomment-4860283591

   This skips the original string conversion logic so the result would be 
incorrect.
   ```python
               def convert_string(value: Any) -> Any:
                   if value is None:
                       if not nullable:
                           raise PySparkValueError(f"input for {dataType} must 
not be None")
                       return None
                   else:
                       if isinstance(value, bool):
                           # To match the PySpark Classic which convert bool to 
string in
                           # the JVM side (python.EvaluatePython.makeFromJava)
                           return str(value).lower()
                       else:
                           return str(value)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to