cloud-fan opened a new pull request, #56989:
URL: https://github.com/apache/spark/pull/56989
### What changes were proposed in this pull request?
`build/mvn` now bridges the `MAVEN_MIRROR_URL` environment variable into
`COURSIER_REPOSITORIES` (as `ivy2Local|${MAVEN_MIRROR_URL}`) just before
invoking `mvn`, when the
caller has not already set `COURSIER_REPOSITORIES`.
### Why are the changes needed?
Some Maven plugins resolve their own dependencies through
[Coursier](https://get-coursier.io/)
rather than through Maven's normal repository resolution. The most visible
example is the
`mvn-scalafmt` plugin invoked by `dev/lint-scala`, which downloads the
scalafmt toolchain
(`scalafmt-core_2.13`, `scala-reflect`) via Coursier.
Coursier does not read `MAVEN_MIRROR_URL`, nor the repositories declared in
the POM (including the
`maven-mirror` profile). In an environment that can only reach an internal
Maven mirror (no direct
access to Maven Central / Sonatype), `dev/lint-scala` therefore fails while
trying to download the
scalafmt toolchain:
```
org.scalafmt.interfaces.ScalafmtException: [v3.8.6] failed to download
download error: Caught java.net.UnknownHostException: repo1.maven.org ...
```
SBT (via `build/sbt-launch-lib.bash`) and Maven (via the `maven-mirror` POM
profile) already honor
`MAVEN_MIRROR_URL`. This change makes Coursier-based plugins honor the same
variable, so mirror-only
environments work out of the box without each developer having to hand-write
a Coursier config
(`~/.config/coursier/mirror.properties`) or export `COURSIER_REPOSITORIES`
themselves. An existing
`COURSIER_REPOSITORIES` set by the caller is respected and not overridden.
### Does this PR introduce _any_ user-facing change?
No. This only affects the local/CI build tooling. When `MAVEN_MIRROR_URL` is
unset (the default),
behavior is unchanged.
### How was this patch tested?
Manually, in a mirror-only environment (Maven Central unreachable):
- Baseline (before the change), running scalafmt via the raw `mvn` binary
fails with
`UnknownHostException: repo1.maven.org` while downloading the scalafmt
toolchain.
- With the change, `./build/mvn scalafmt:format ...` and the full
`./dev/lint-scala` both succeed
("Scalastyle checks passed." / "Scalafmt checks passed."), resolving the
toolchain through the
mirror, with `COURSIER_REPOSITORIES` unset in the environment.
- Verified the guard branches: an existing `COURSIER_REPOSITORIES` is left
untouched, and when
`MAVEN_MIRROR_URL` is unset nothing is exported.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.8)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
