shrirangmhalgi commented on code in PR #56997:
URL: https://github.com/apache/spark/pull/56997#discussion_r3523280268


##########
docs/sparkr-migration-guide.md:
##########
@@ -26,6 +26,10 @@ Note that this migration guide describes the items specific 
to SparkR.
 Many items of SQL migration can be applied when migrating SparkR to higher 
versions.
 Please refer [Migration Guide: SQL, Datasets and 
DataFrame](sql-migration-guide.html).
 
+## Upgrading from SparkR 4.0 to 4.3
+
+ - In Spark 4.1, `TimeType` support was added. But SparkR does not support 
`TimeType` and creating or collecting `TimeType` column would raise an error.

Review Comment:
   The section header says "Upgrading from SparkR 4.0 to 4.3" but the bullet 
says "In Spark 4.1, TimeType support was added." These are inconsistent - 
`TimeType` is targeting 4.3 (all `TIME`-related configs/functions use 
version("4.3.0") in the codebase). Should the bullet read "In Spark 4.3" 
instead?
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to