uros-b commented on code in PR #56944:
URL: https://github.com/apache/spark/pull/56944#discussion_r3524897242
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/operators/stateful/statefulOperators.scala:
##########
@@ -671,17 +672,35 @@ object WatermarkSupport {
// use the attribute itself.
val evictionExpression =
if (watermarkAttribute.dataType.isInstanceOf[StructType]) {
Review Comment:
It seems that the struct branch's new endFieldType handling is currently
inert. window()/session_window() over nanos is still rejected upstream (arrives
with SPARK-57829 / #56951), so end is always micros and watermarkLiteral
returns the same value as before. Hence, this is dead/untested today?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
