uros-b commented on code in PR #56974:
URL: https://github.com/apache/spark/pull/56974#discussion_r3524898839
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/codegen/UnsafeRowWriterSuite.scala:
##########
@@ -23,6 +23,58 @@ import org.apache.spark.unsafe.types._
class UnsafeRowWriterSuite extends SparkFunSuite {
+ test("writeNullable matches the setNullAt/write split for null and non-null
inputs") {
Review Comment:
Nit: the new unit test covers int, UTF8String, wide+compact decimal, and
CalendarInterval, but omits TimestampNanosVal (and VariantVal). TimestampNanos
is the other slot-reserving overload with bespoke null semantics
(write(ordinal, isNull ? null : value) reserving the 16-byte slot); it is the
one new-logic overload left unexercised by direct test. Please consider adding
a two-case assertion that would make the reserved-slot null contract explicit
and guard against regression.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
