uros-b commented on code in PR #56976:
URL: https://github.com/apache/spark/pull/56976#discussion_r3524961721
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala:
##########
@@ -177,6 +177,17 @@ case class HashAggregateExec(
TaskContext.get()
}
+ /**
+ * Registers a task-completion hook to close the generated fast hash map.
This is called by the
+ * generated Java class so that the close hook is a plain method call on
this plan, with the
+ * listener being a lambda in compiled Scala code, rather than an anonymous
+ * `TaskCompletionListener` emitted per fast hash map (one fewer generated
inner class per map).
+ * Should be public.
Review Comment:
The last line reads a bit awkward in this prose. Can we make this consistent
with some other scaladocs? e.g. `This is called by <XYZ>, should be public.`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
