iRakson opened a new pull request, #57013:
URL: https://github.com/apache/spark/pull/57013

   ### What changes were proposed in this pull request?
   Add support for TimeType to approx_top_k. After this change approx_top_k 
accepts TimeType and returns correct top-k time values and columns. 
   
   
   ### Why are the changes needed?
   The TIME data type was added by SPIP 
[SPARK-51162](https://issues.apache.org/jira/browse/SPARK-51162) and shipped in 
Spark 4.1.0, but the approx_top_k aggregate functions did not accept it. 
Calling approx_top_k on a TIME column failed with a type-check error, even 
though the operation is well-defined. This PR closes that gap.
   
   ### Does this PR introduce _any_ user-facing change?
   Yes, Now users can use approx_top_k over TimeType columns as well.
   
   
   ### How was this patch tested?
   UTs added.
   
   
   ### Was this patch authored or co-authored using generative AI tooling?
   Used claude code for UTs.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to