yadavay-amzn commented on PR #56984: URL: https://github.com/apache/spark/pull/56984#issuecomment-4888018810
Scope note from the review discussion (cc @shrirangmhalgi @uros-b): the forward-looking window-struct-over-nanos watermark guard I had added to CheckAnalysis was inert on this PR, because window()/session_window() over nanos is not enabled until SPARK-57829. Per @uros-b's cross-PR observation on #56944, I consolidated all window-struct-over-nanos handling into #56951 (SPARK-57829), where it is reachable and e2e-tested. This PR reverts that guard to its original form and stays scoped to the reachable scalar nanos path; the dead-code cleanup and the NTZ / UpdateEventTimeColumnExec error-path tests are unchanged, so the approvals should still hold. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
