aajisaka commented on PR #55028: URL: https://github.com/apache/spark/pull/55028#issuecomment-4891256187
Thank you for the detailed review. I really appreciate it. > `testSplitHeader` exercises a split inside the Tink header nicely. The new partial-fill path for the 8-byte length prefix itself (say a split at byte 4) isn't directly covered, cheap to add a case for if you want the symmetry. Added testSplitLengthPrefix to cover. Also, renamed `testSplitHeader` to `testSplitGcmHeader`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
