uros-db commented on PR #56891: URL: https://github.com/apache/spark/pull/56891#issuecomment-4892768104
@MaxGekk On the MISSING_AGGREGATION → MISSING_GROUP_BY change: this is intentional and emergent from the fix rather than a deliberate message choice. Once GROUP BY GROUPING SETS (()) lowers to a global Aggregate with no grouping expressions, the plan is structurally identical to a no-GROUP BY aggregation, so a non-aggregated select column takes the same MISSING_GROUP_BY path that SELECT c1 FROM t (no GROUP BY) would. I agree the "Add GROUP BY" remedy reads slightly oddly given the query does have a GROUP BY clause, but the new error is arguably more accurate about the underlying problem (the grand total groups by nothing), and it matches the no-GROUP BY form the PR is deliberately aligning with. All other comments addressed, thank you for review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
