daniel-lunin-db opened a new pull request, #57042:
URL: https://github.com/apache/spark/pull/57042
Add unit tests for Analyzer.buildSQLFunctionConf covering ANSI handling: a
persisted ANSI value makes the alwaysSetAnsiValue flag a no-op, and the flag
only takes effect when ANSI is not persisted (under
ASSUME_ANSI_FALSE_IF_NOT_PERSISTED).
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR:
https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a
faster review.
7. If you want to add a new configuration, please read the guideline first
for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the
guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
Add two unit tests in `AnalysisSuite` for `Analyzer.buildSQLFunctionConf`,
the helper
that constructs the throwaway `SQLConf` used to resolve a SQL UDF body. The
tests pin
the interaction between the `alwaysSetAnsiValue` parameter and a SQL UDF's
persisted
ANSI config:
- When `spark.sql.ansi.enabled` is persisted in the function's stored
configs, the
persisted value wins and `alwaysSetAnsiValue` is a no-op (checked with
session
overrides both on and off).
- When ANSI is not persisted, `alwaysSetAnsiValue=true` seeds it to `false`
(via
`ASSUME_ANSI_FALSE_IF_NOT_PERSISTED`) while `alwaysSetAnsiValue=false`
leaves it
unset.
### Why are the changes needed?
`buildSQLFunctionConf` was extracted in SPARK-57756 (#56895) but only had
coverage
through the existing end-to-end SQL UDF resolution tests. These add direct
unit
coverage for the ANSI-seeding branch, which is the subtle part of the helper.
### Does this PR introduce _any_ user-facing change?
No. Tests only.
### How was this patch tested?
New tests in `AnalysisSuite`; CI runs them.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Anthropic Claude Opus)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
