uros-b commented on code in PR #57010: URL: https://github.com/apache/spark/pull/57010#discussion_r3535264733
########## docs/_plugins/build_api_docs.rb: ########## @@ -277,10 +281,12 @@ def build_spark_scala_and_java_docs_if_necessary def build_scala_and_java_docs build_spark_if_necessary - print_header "Building Scala and Java API docs." + print_header "Building Scala and Java API docs" cd(SPARK_PROJECT_ROOT) - build_spark_scala_and_java_docs_if_necessary + if not (ENV['SKIP_UNIDOC'] == '1') Review Comment: Please check possible latent inconsistency: SKIP_UNIDOC reuses a name that already exists cross-subsystem; dev/run-tests.py:307 reads it via truthiness and multiple non-doc CI jobs set SKIP_UNIDOC: true, whereas the doc script gates strictly on == '1'. No live conflict (the docs job at lines 1246-1577 sets neither new flag, so it builds both as before, and no CI path both exports SKIP_UNIDOC=true and runs the Jekyll build), but a user exporting SKIP_UNIDOC=true expecting the doc build to skip would be surprised. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
