cloud-fan commented on code in PR #57075:
URL: https://github.com/apache/spark/pull/57075#discussion_r3538506898
##########
core/src/main/scala/org/apache/spark/internal/config/package.scala:
##########
@@ -586,6 +586,18 @@ package object config {
.checkValue(_ > 0, "The maximum number of threads should be positive")
.createWithDefault(8)
+ private[spark] val STORAGE_DECOMMISSION_SHUFFLE_BUFFER_RACING_MIGRATIONS =
+
ConfigBuilder("spark.storage.decommission.shuffleBlocks.bufferRacingMigrations")
+ .internal()
+ .doc("Whether to buffer a shuffle-migration relocation report that
arrives before the " +
+ "map output it relocates has been registered on the driver, and replay
it once " +
+ "registration happens. When false, such a relocation is dropped
(legacy behavior), " +
+ "which can leave the map output pointing at the decommissioned origin
executor and " +
+ "surface downstream as a fetch failure once that executor is removed.")
+ .version("5.0.0")
Review Comment:
This is a backportable correctness fix and the identical `ShuffleStatus`
code already exists on `branch-4.x` (4.3.0-SNAPSHOT), so per Spark's versioning
policy the config should carry the next-open-release version rather than
master's:
```suggestion
.version("4.3.0")
```
Non-blocking — only matters if you intend this to backport (which the fix
seems to warrant).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
