dongjoon-hyun commented on code in PR #57077: URL: https://github.com/apache/spark/pull/57077#discussion_r3539812510
########## sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala: ########## @@ -987,7 +987,7 @@ case class UnionExec(children: Seq[SparkPlan]) extends SparkPlan with CodegenSup // codegen is disabled for it (`supportCodegenFailureReason` reports "partitioning-aware"): // the per-partition key descriptor is consumed by a downstream `GroupPartitionsExec`, and // keeping these unions out of whole-stage codegen matches the `HashPartitioning` union case. - private def isPlainUnion: Boolean = outputPartitioning.isInstanceOf[UnknownPartitioning] + private[spark] def isPlainUnion: Boolean = outputPartitioning.isInstanceOf[UnknownPartitioning] Review Comment: `private[spark]` -> `private[sql]` because we prefer to use the narrowest one like the following in this file? https://github.com/apache/spark/blob/5a63d3a989a1aee4c9000e2137b00bde204b2706/sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala#L1415 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
