szehon-ho commented on code in PR #56985:
URL: https://github.com/apache/spark/pull/56985#discussion_r3539911511
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/command/CreatePipelineDatasetAsSelectParserSuiteBase.scala:
##########
@@ -86,6 +86,18 @@ trait CreatePipelineDatasetAsSelectParserSuiteBase extends
CommandSuiteBase {
}
}
+ test("Clustering is correctly parsed") {
Review Comment:
Nice addition — putting `CLUSTER BY` here correctly covers both
`CreateStreamingTableAsSelectParserSuite` and
`CreateMaterializedViewAsSelectParserSuite`. (Alternatively this could extend
the existing `"Partitioning is correctly parsed"` test, but a separate test is
clearer since `CLUSTER BY` and `PARTITIONED BY` produce different transform
types.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
