gaogaotiantian opened a new pull request, #57093:
URL: https://github.com/apache/spark/pull/57093
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR:
https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a
faster review.
7. If you want to add a new configuration, please read the guideline first
for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the
guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section
is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster
reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class
hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other
DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
1. Moved the dependency list from `requirements.txt` to `pyproject.toml`
(`requirements.txt` file is not deleted in this PR for compatibility, it will
eventually be removed).
2. Update the docs, including `AGENTS.md`, to use `pyprojec.toml` instead of
`dev/requirements.txt`.
3. Fixed some leftover reference to `black` where we already use `ruff`.
4. Added the explanation for both human and agents to use `pip>=25.1` which
supports the dependency groups.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
5. If you fix a bug, you can clarify why it is a bug.
-->
This is just the first step of an important project - to put all of our
python dependencies in a single place. To be more specific, dependencies for
1. development (currently `requirements.txt`)
2. CI (individually defined in docker files and workflow files)
3. packaging (defined in `setup.py`)
Every time we change a dependency, we need to change it all over our code
base and we probably will miss some. What's even worse is that we had to pin
dependencies for different release branches.
With the effort to decouple CI, we basically solve the release branch
dependency issue (except for 4.2 which has been in rc stage for a while - I
want to wait for its release to decouple it). We don't need to keep
dependencies for different release branches anymore.
Now we want to move dependency pins from docker files and workflows to
`pyproject.toml` - `requirements.txt` can't do it because the testing
environment is complicated. They share some dependencies but also require
different ones for each workflow. We need group structure to make it possible
and that's where [dependency
group](https://packaging.python.org/en/latest/specifications/dependency-groups/)
comes in. It's a relatively new feature
[PEP-735](https://peps.python.org/pep-0735/) which was supported by `pip` on
April 2025 (more than a year ago). `uv sync` also supports it.
I believe with this approach, we can eliminate all the dependencies in the
docker file and workflow file. We should be able to have a single source of
truth of the Python dependency. And it will be more structured.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as
new features, bug fixes, or other behavior changes. Documentation-only updates
are not considered user-facing changes.
If yes, please clarify the previous behavior and the change this PR proposes
- provide the console output, description and/or an example to show the
behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to
the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some
test cases that check the changes thoroughly including negative and positive
cases if possible.
If it was tested in a way different from regular unit tests, please clarify
how you tested step by step, ideally copy and paste-able, so that other
reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why
it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions
for the consistent environment, and the instructions could accord to:
https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
This PR should not affect CI.
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this
patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling
Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
