Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/6725#discussion_r32375281
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala
---
@@ -254,3 +254,52 @@ case class Pow(left: Expression, right: Expression)
"""
}
}
+
+object Logarithm {
+ def apply(child: Expression): Expression = new Log(child)
+}
+
+case class Logarithm(left: Expression, right: Expression)
+ extends BinaryMathExpression((c1, c2) => math.log(c2) / math.log(c1),
"LOG") {
--- End diff --
I would argue that that function is also implemented in a confusing way.
We should not shoehorn things into the class hierarchy if its going to result
hard to follow code. I'd rather we have small amounts of code duplication.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
