marcuslin123 opened a new pull request, #57108:
URL: https://github.com/apache/spark/pull/57108

   ### What changes were proposed in this pull request?
   
   Fix the `messageParameters` key in 
`SparkConnectGraphElementRegistry.register_output` from `output_type` to 
`dataset_type` at both raise sites, matching the 
`UNSUPPORTED_PIPELINES_DATASET_TYPE` error template which interpolates 
`<dataset_type>`.
   
   ### Why are the changes needed?
   
   The mismatch between the template placeholder (`<dataset_type>`) and the 
provided parameter key (`output_type`) causes 
`ErrorClassesReader.get_error_message` to fire an assertion, replacing the 
intended `PySparkTypeError` with an opaque `AssertionError`. Users see a 
confusing internal crash instead of the helpful "Unsupported pipelines dataset 
type: X" message.
   
   ### Does this PR introduce _any_ user-facing change?
   
   Yes. Users who pass an unsupported output type to Declarative Pipelines will 
now see:
   
   ```
   PySparkTypeError: [UNSUPPORTED_PIPELINES_DATASET_TYPE] Unsupported pipelines 
dataset type: SomeClass.
   ```
   
   Instead of the previous opaque `AssertionError`.
   
   ### How was this patch tested?
   
   Added a regression test in `test_graph_element_registry.py` that constructs 
`PySparkTypeError` with `UNSUPPORTED_PIPELINES_DATASET_TYPE` and verifies the 
error message is produced without assertion failures.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   Generative AI tooling (Claude Code) was used as an assistive tool for 
implementation guidance.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to