dongjoon-hyun commented on code in PR #57110:
URL: https://github.com/apache/spark/pull/57110#discussion_r3541364927
##########
sql/api/src/main/scala/org/apache/spark/sql/catalyst/util/SparkDateTimeUtils.scala:
##########
@@ -43,10 +43,20 @@ trait SparkDateTimeUtils {
def getZoneId(timeZoneId: String): ZoneId = {
try {
- // To support the (+|-)h:mm format because it was supported before Spark
3.0.
- var formattedZoneId =
singleHourTz.matcher(timeZoneId).replaceFirst("$10$2:")
- // To support the (+|-)hh:m format because it was supported before Spark
3.0.
- formattedZoneId =
singleMinuteTz.matcher(formattedZoneId).replaceFirst("$1$2:0$3")
+ // The (+|-)h:mm and (+|-)hh:m formats (supported before Spark 3.0) both
start with a sign
Review Comment:
Although `getZoneId("GMT+8:00")` worked before, we don't support it, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
