nchammas commented on PR #57015: URL: https://github.com/apache/spark/pull/57015#issuecomment-4917446650
> You can test it out in your Spark fork, which needs no approval. I don't think that will help me since I'm specifically trying to get annotations to write to PRs on this repo. In any case, thank you for approving the workflow. Inline annotations are working! This is very exciting. <img width="800" src="https://github.com/user-attachments/assets/b8f412bf-0714-4ff0-9565-368b15f8759f"; /> @cloud-fan - I think if we updated several of our workflows to follow the pattern of this new [docs workflow](https://github.com/apache/spark/blob/5e080fe69e8d3427e9e6d119c1423a8591cf1308/.github/workflows/docs.yml) it would be a very nice productivity boost. In addition to having annotations at the top of the workflow log, contributors would also have inline annotations right on the PR diff. They won't even have to open the workflow logs to see what's wrong. Do like the direction this is going in? I can wrap up this PR with the focus on javadoc errors and establishing this new pattern. In follow ups I can then migrate the various linter and other workflows to adopt this pattern and also place inline annotations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
