dongjoon-hyun opened a new pull request, #435:
URL: https://github.com/apache/spark-connect-swift/pull/435

   ### What changes were proposed in this pull request?
   
   Replace release-stripped `assert(...)` calls with `guard`/`throw` validation 
and add `SparkConnectError.InvalidArrowData`:
   
   - `DataFrame.execute()` — validate Arrow IPC continuation tokens and 
bounds-check server-supplied sizes before slicing.
   - `DataFrame.show()` — require one row / one column before accessing 
`rows[0]`.
   - `DataFrameWriter.executeWriteOperation` — reject `path` and `tableName` 
both set.
   - `SparkSession.Builder.create()` — require `setConf` success.
   
   ### Why are the changes needed?
   
   `assert(...)` is compiled out in release builds, so these checks never ran 
in production. A malformed server response could trap while slicing on 
unvalidated sizes. `guard`/`throw` makes the checks effective in release and 
turns traps into recoverable errors.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   Pass the CIs.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Opus 4.8


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to