gengliangwang commented on PR #57131: URL: https://github.com/apache/spark/pull/57131#issuecomment-4919629616
Thanks @dongjoon-hyun! Good call on both — it works for both patterns: - **`[FOLLOWUP]`**: the JIRA id is extracted from the title regardless of the tag, so verification runs on the referenced ticket. A follow-up usually reuses the parent's (now-`Resolved`) ticket, so the Resolved/Closed warning tends to fire, and a reworded follow-up title can also trip the low-similarity warning — both advisory `y/N`, not hard blocks. - **`Revert "..."`**: the title is kept verbatim and the id is still extracted from it, so it points at the original ticket and shows the warnings — the intended nudge to double-check. I've added `title_similarity` doctests for both patterns (973733bff4e): the `[FOLLOWUP]` tag is stripped like any bracket tag (still scores 1.0 on a match), and the `Revert "..."` prefix stays verbatim (the extra word lowers the score but a genuine match still scores well above the threshold). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
