Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6725#discussion_r32375632
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala
 ---
    @@ -90,18 +90,26 @@ abstract class UnaryMathExpression(f: Double => Double, 
name: String)
     }
     
     /**
    + * A binary expression specifically for math functions that take two input 
parameters and
    + * returns one output value.
    + * @param name The short name of the function
    + */
    +abstract class AbstractBinaryMathExpression[T, U, V](name: String)
    --- End diff --
    
    yes let's not complicate the type hierarchy just for one thing


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to