vranes commented on code in PR #57157:
URL: https://github.com/apache/spark/pull/57157#discussion_r3560391631


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala:
##########
@@ -1135,6 +1135,13 @@ object ColumnPruning extends Rule[LogicalPlan] {
         .map(_._2)
       p.copy(child = g.copy(child = newChild, unrequiredChildIndex = 
unrequiredIndices))
 
+    // prune unused pass-through columns from the child of BinBy. The range 
and DISTRIBUTE inputs
+    // the kernel reads are kept via `b.references`; only fully-unused 
pass-throughs are dropped.
+    case p @ Project(_, b: BinBy)

Review Comment:
    Good catch, you're right.  Removed the arm. I kept the test (it still 
passes) and retitled/reframed the PR + JIRA since it's now test-only.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to