gengliangwang commented on code in PR #56617:
URL: https://github.com/apache/spark/pull/56617#discussion_r3561364481
##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/SupportsCatalogOptions.java:
##########
@@ -55,6 +55,35 @@ default String extractCatalog(CaseInsensitiveStringMap
options) {
return CatalogManager.SESSION_CATALOG_NAME();
}
+ /**
+ * Whether this interface should be used for table existence checks or
creation.
+ * A source may override it to dynamically enable the behavior provided by
+ * SupportsCatalogOptions as they migrate from regular file-based data
source behavior.
Review Comment:
Subject/pronoun disagreement: the singular "A source" (line 60) is referred
to as plural "they".
```suggestion
* SupportsCatalogOptions as it migrates from regular file-based data
source behavior.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
