viirya commented on PR #57099: URL: https://github.com/apache/spark/pull/57099#issuecomment-4939594733
@gaogaotiantian Both done in 5ce205e5d3a: 1. The module-level block is gone — the version and NumPy checks are folded into a single `ArrowTableToRowsConversion._should_manual_bulk()` staticmethod with `@functools.cache` (I put it on `ArrowTableToRowsConversion` since that's the class that owns `_to_pylist`). Tests patch the method directly instead of poking module globals, so removing the whole thing later is a clean two-site deletion. 2. Both docstrings now state the helpers are internal-only and that they (together with the manual bulk paths) *should* be removed once the minimum supported PyArrow version contains the fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
