Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6810#discussion_r32375944
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/GeneratedAggregate.scala
---
@@ -270,7 +270,9 @@ case class GeneratedAggregate(
val joinedRow = new JoinedRow3
- if (groupingExpressions.isEmpty) {
+ if (!iter.hasNext) {
+ Iterator[InternalRow]()
--- End diff --
Can we add a comment here to explain why we're doing this? Just needs to
mention the memory leak issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
